[coreboot-gerrit] New patch to review for coreboot: coreinfo: Use regular `if` over `#if` for `IS_ENABLED`

Nicola Corna (nicola@corna.info) gerrit at coreboot.org
Tue Mar 14 17:37:04 CET 2017


Nicola Corna (nicola at corna.info) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18811

-gerrit

commit 0febba1c8df237917407ac79865730f0cd0ad209
Author: Nicola Corna <nicola at corna.info>
Date:   Tue Mar 14 10:26:58 2017 +0100

    coreinfo: Use regular `if` over `#if` for `IS_ENABLED`
    
    When using the regular `if` construct, the compiler will check
    the guarded code independently from the condition.
    
    Change-Id: I00c5c7ae3720f75aa9415edb94cd2ce76cee8aee
    Signed-off-by: Nicola Corna <nicola at corna.info>
---
 payloads/coreinfo/coreinfo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c
index 3fb2f72..718c589 100644
--- a/payloads/coreinfo/coreinfo.c
+++ b/payloads/coreinfo/coreinfo.c
@@ -291,9 +291,8 @@ int main(void)
 {
 	int i, j;
 
-#if IS_ENABLED(CONFIG_LP_USB)
-	usb_initialize();
-#endif
+	if (IS_ENABLED(CONFIG_LP_USB))
+		usb_initialize();
 
 	initscr();
 



More information about the coreboot-gerrit mailing list