[coreboot-gerrit] Patch merged into coreboot/master: src/lib: Fix spacing

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 13 17:16:11 CET 2017


the following patch was just integrated into master:
commit 35af5c47b030c0a1837cb34bc9ae4d50734fefb0
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Thu Mar 9 17:35:28 2017 -0800

    src/lib: Fix spacing
    
    Fix the following errors and warnings detected by checkpatch.pl:
    
    ERROR: spaces required around that '?' (ctx:WxV)
    ERROR: spaces required around that '=' (ctx:VxV)
    ERROR: spaces required around that '<' (ctx:VxV)
    ERROR: spaces required around that '+=' (ctx:VxV)
    ERROR: space required after that ',' (ctx:VxV)
    ERROR: space required before the open brace '{'
    ERROR: space required after that close brace '}'
    ERROR: need consistent spacing around '+' (ctx:WxV)
    ERROR: need consistent spacing around '*' (ctx:WxV)
    ERROR: need consistent spacing around '&' (ctx:VxW)
    ERROR: spaces required around that '?' (ctx:VxW)
    ERROR: spaces required around that ':' (ctx:VxW)
    ERROR: trailing whitespace
    ERROR: space prohibited before that '++' (ctx:WxO)
    ERROR: space prohibited before that ',' (ctx:WxW)
    ERROR: space prohibited after that '!' (ctx:BxW)
    ERROR: spaces prohibited around that '->' (ctx:VxW)
    ERROR: space prohibited after that '-' (ctx:WxW)
    WARNING: space prohibited before semicolon
    WARNING: unnecessary whitespace before a quoted newline
    WARNING: missing space after return type
    
    Note that lib/libgcov.c and lib/lzmadecode.c are providing false
    positives for ERROR: need consistent spacing around '*' (ctx:WxV)
    An example is:
    void __gcov_merge_add(gcov_type *counters  __attribute__ ((unused)),
          unsigned int n_counters __attribute__ ((unused))) {}
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I0016327a5754018eaeb25bedf42338291632c7c1
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/18733
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/18733 for details.

-gerrit



More information about the coreboot-gerrit mailing list