[coreboot-gerrit] New patch to review for coreboot: emulation/qemu-i440fx: Use SMBIOS macros

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Mar 13 12:09:44 CET 2017


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18790

-gerrit

commit fcd90b68df086432a54ea96b784788abe1b6c635
Author: Paul Menzel <pmenzel at molgen.mpg.de>
Date:   Sun Mar 12 18:18:06 2017 +0100

    emulation/qemu-i440fx: Use SMBIOS macros
    
    Change-Id: Idda4d74f9b934ccefe6ea5b553bde587059cde64
    Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
---
 src/mainboard/emulation/qemu-i440fx/northbridge.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index 575069c..f70c240 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -177,9 +177,9 @@ static int qemu_get_smbios_data16(int handle, unsigned long *current)
 	t->type = SMBIOS_PHYS_MEMORY_ARRAY;
 	t->handle = handle;
 	t->length = len - 2;
-	t->location = 3; /* Location: System Board */
-	t->use = 3; /* System memory */
-	t->memory_error_correction = 3; /* No error correction */
+	t->location = MEMORY_ARRAY_LOCATION_SYSTEM_BOARD;
+	t->use = MEMORY_ARRAY_USE_SYSTEM;
+	t->memory_error_correction = MEMORY_ARRAY_USE_SYSTEM;
 	t->maximum_capacity = qemu_get_memory_size();
 	*current += len;
 	return len;



More information about the coreboot-gerrit mailing list