[coreboot-gerrit] Patch set updated for coreboot: google/sand: Remove support for tablet mode switch

Katherine Hsieh (Katherine.Hsieh@quantatw.com) gerrit at coreboot.org
Mon Mar 13 03:21:46 CET 2017


Katherine Hsieh (Katherine.Hsieh at quantatw.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18737

-gerrit

commit 2a38302262c1803743561ae40885e8228da8aac3
Author: Katherine Hsieh <Katherine.Hsieh at quantatw.com>
Date:   Fri Mar 10 21:49:44 2017 +0800

    google/sand: Remove support for tablet mode switch
    
    Sand is not convertible and no EC sensor sends event from EC to AP.
    That event default is tablet mode, we don't have to enable tablet event.
    
    Modify the ec.h, is based on <baseboard/ec.h>
    
    BUG=b:36108742
    BRANCH=reef
    TEST=emerge-sand coreboot, boot to OS and touchpad and keyboard can work.
    
    Change-Id: I6b6b45b5b4daf2c430ed18130f39eab0bd9a9812
    Signed-off-by: Katherine Hsieh <Katherine.Hsieh at quantatw.com>
---
 .../google/reef/variants/sand/include/variant/ec.h | 64 +++++++++++++++++++++-
 1 file changed, 62 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/reef/variants/sand/include/variant/ec.h b/src/mainboard/google/reef/variants/sand/include/variant/ec.h
index 94424e1..80cf806 100644
--- a/src/mainboard/google/reef/variants/sand/include/variant/ec.h
+++ b/src/mainboard/google/reef/variants/sand/include/variant/ec.h
@@ -13,5 +13,65 @@
  * GNU General Public License for more details.
  */
 
-/* Use the one from baseboard for now */
-#include <baseboard/ec.h>
+#ifndef BASEBOARD_EC_H
+#define BASEBOARD_EC_H
+
+#include <variant/gpio.h>
+#include <ec/google/chromeec/ec_commands.h>
+
+#define MAINBOARD_EC_SCI_EVENTS \
+	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED)        |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN)          |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED)      |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED)   |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW)       |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)  |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)              |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU))
+
+#define MAINBOARD_EC_SMI_EVENTS \
+	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))
+
+/* EC can wake from S5 with lid or power button */
+#define MAINBOARD_EC_S5_WAKE_EVENTS \
+	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN)     |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))
+
+/* EC can wake from S3 with lid or power button or key press */
+#define MAINBOARD_EC_S3_WAKE_EVENTS \
+	(MAINBOARD_EC_S5_WAKE_EVENTS |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED))
+
+/* Log EC wake events plus EC shutdown events */
+#define MAINBOARD_EC_LOG_EVENTS \
+	(EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN)|\
+	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC))
+
+/*
+ * ACPI related definitions for ASL code.
+ */
+
+/* Enable EC backed ALS device in ACPI */
+#define EC_ENABLE_ALS_DEVICE
+
+/* Enable EC backed PD MCU device in ACPI */
+#define EC_ENABLE_PD_MCU_DEVICE
+
+/* Enable LID switch and provide wake pin for EC */
+#define EC_ENABLE_LID_SWITCH
+#define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
+
+
+#define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */
+#define SIO_EC_HOST_ENABLE       /* EC Host Interface Resources */
+#define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */
+
+#endif



More information about the coreboot-gerrit mailing list