[coreboot-gerrit] Patch set updated for coreboot: src/include: Fix space between type, * and variable name
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Sun Mar 12 19:08:12 CET 2017
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18655
-gerrit
commit 475b2cfa5f5d115a8b7cb3b87dc5bb045baf1c3e
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Tue Mar 7 15:24:16 2017 -0800
src/include: Fix space between type, * and variable name
Fix the following errors detected by checkpatch.pl:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo* bar" should be "foo *bar"
ERROR: "foo*bar" should be "foo *bar"
TEST=Build and run on Galileo Gen2
Change-Id: I5a3ff8b92e3ceecb4ddf45d8840454d5310fc6b3
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
src/include/cpu/amd/powernow.h | 2 +-
src/include/cpu/intel/romstage.h | 2 +-
src/include/cpu/x86/lapic.h | 2 +-
src/include/device/device.h | 24 ++++++++++++------------
src/include/device/dram/ddr3.h | 6 +++---
src/include/device/pci.h | 2 +-
src/include/device/resource.h | 10 +++++-----
src/include/string.h | 2 +-
8 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/src/include/cpu/amd/powernow.h b/src/include/cpu/amd/powernow.h
index fc1e863..6396815 100644
--- a/src/include/cpu/amd/powernow.h
+++ b/src/include/cpu/amd/powernow.h
@@ -18,6 +18,6 @@
#define POWERNOW_H
void amd_generate_powernow(u32 pcontrol_blk, u8 plen, u8 onlyBSP);
-void amd_powernow_update_fadt(acpi_fadt_t * fadt);
+void amd_powernow_update_fadt(acpi_fadt_t *fadt);
#endif
diff --git a/src/include/cpu/intel/romstage.h b/src/include/cpu/intel/romstage.h
index 1f967ce..0dd02ce 100644
--- a/src/include/cpu/intel/romstage.h
+++ b/src/include/cpu/intel/romstage.h
@@ -24,7 +24,7 @@ void *setup_stack_and_mtrrs(void);
/* romstage_main is called from the cache-as-ram assembly file to prepare
* CAR stack guards.*/
-void * asmlinkage romstage_main(unsigned long bist);
+asmlinkage void *romstage_main(unsigned long bist);
/* romstage_after_car() is the C function called after cache-as-ram has
* been torn down. It is responsible for loading the ramstage. */
void asmlinkage romstage_after_car(void);
diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h
index 3448ced..540e985 100644
--- a/src/include/cpu/x86/lapic.h
+++ b/src/include/cpu/x86/lapic.h
@@ -77,7 +77,7 @@ struct __xchg_dummy { unsigned long a[100]; };
* Note 2: xchg has side effect, so that attribute volatile is necessary,
* but generally the primitive is invalid, *ptr is output argument. --ANK
*/
-static inline unsigned long __xchg(unsigned long x, volatile void * ptr, int size)
+static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size)
{
switch (size) {
case 1:
diff --git a/src/include/device/device.h b/src/include/device/device.h
index e60277d..74ec508 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -17,7 +17,7 @@
struct device;
#ifndef __SIMPLE_DEVICE__
-typedef struct device * device_t;
+typedef struct device *device_t;
struct pci_operations;
struct pci_bus_operations;
struct i2c_bus_operations;
@@ -82,9 +82,9 @@ static inline void device_noop(struct device *dev) {}
struct bus {
- ROMSTAGE_CONST struct device * dev; /* This bridge device */
- ROMSTAGE_CONST struct device * children; /* devices behind this bridge */
- ROMSTAGE_CONST struct bus *next; /* The next bridge on this device */
+ ROMSTAGE_CONST struct device *dev; /* This bridge device */
+ ROMSTAGE_CONST struct device *children; /* devices behind this bridge */
+ ROMSTAGE_CONST struct bus *next; /* The next bridge on this device */
unsigned int bridge_ctrl; /* Bridge control register */
uint16_t bridge_cmd; /* Bridge command register */
unsigned char link_num; /* The index of this link */
@@ -111,12 +111,12 @@ struct pci_irq_info {
};
struct device {
- ROMSTAGE_CONST struct bus * bus; /* bus this device is on, for bridge
+ ROMSTAGE_CONST struct bus *bus; /* bus this device is on, for bridge
* devices, it is the up stream bus */
- ROMSTAGE_CONST struct device * sibling; /* next device on this bus */
+ ROMSTAGE_CONST struct device *sibling; /* next device on this bus */
- ROMSTAGE_CONST struct device * next; /* chain of all devices */
+ ROMSTAGE_CONST struct device *next; /* chain of all devices */
struct device_path path;
unsigned int vendor;
@@ -214,7 +214,7 @@ void set_cpu_topology(device_t cpu, unsigned int node, unsigned int package, uns
set_cpu_topology(cpu, 0, package, core, thread)
/* Debug functions */
-void print_resource_tree(struct device * root, int debug_level,
+void print_resource_tree(struct device *root, int debug_level,
const char *msg);
void show_devs_tree(struct device *dev, int debug_level, int depth);
void show_devs_subtree(struct device *root, int debug_level, const char *msg);
@@ -222,7 +222,7 @@ void show_all_devs(int debug_level, const char *msg);
void show_all_devs_tree(int debug_level, const char *msg);
void show_one_resource(int debug_level, struct device *dev,
struct resource *resource, const char *comment);
-void show_all_devs_resources(int debug_level, const char* msg);
+void show_all_devs_resources(int debug_level, const char *msg);
/* Rounding for boundaries.
* Due to some chip bugs, go ahead and round IO to 16
@@ -268,13 +268,13 @@ u32 find_pci_tolm(struct bus *bus);
#else /* vv __SIMPLE_DEVICE__ vv */
-ROMSTAGE_CONST struct device * dev_find_slot (unsigned int bus,
+ROMSTAGE_CONST struct device *dev_find_slot (unsigned int bus,
unsigned int devfn);
ROMSTAGE_CONST struct device *dev_find_next_pci_device(
ROMSTAGE_CONST struct device *previous_dev);
-ROMSTAGE_CONST struct device * dev_find_slot_on_smbus (unsigned int bus,
+ROMSTAGE_CONST struct device *dev_find_slot_on_smbus (unsigned int bus,
unsigned int addr);
-ROMSTAGE_CONST struct device * dev_find_slot_pnp(u16 port, u16 device);
+ROMSTAGE_CONST struct device *dev_find_slot_pnp(u16 port, u16 device);
#endif
diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h
index 7a97bf8..11f98c5 100644
--- a/src/include/device/dram/ddr3.h
+++ b/src/include/device/dram/ddr3.h
@@ -200,10 +200,10 @@ typedef u8 spd_raw_data[256];
u16 spd_ddr3_calc_crc(u8 *spd, int len);
u16 spd_ddr3_calc_unique_crc(u8 *spd, int len);
-int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd_data);
+int spd_decode_ddr3(dimm_attr *dimm, spd_raw_data spd_data);
int spd_dimm_is_registered_ddr3(enum spd_dimm_type type);
-void dram_print_spd_ddr3(const dimm_attr * dimm);
-int spd_xmp_decode_ddr3(dimm_attr * dimm,
+void dram_print_spd_ddr3(const dimm_attr *dimm);
+int spd_xmp_decode_ddr3(dimm_attr *dimm,
spd_raw_data spd,
enum ddr3_xmp_profile profile);
diff --git a/src/include/device/pci.h b/src/include/device/pci.h
index e18a09a..a8e7f8b 100644
--- a/src/include/device/pci.h
+++ b/src/include/device/pci.h
@@ -89,7 +89,7 @@ void pci_dev_set_subsystem(device_t dev, unsigned int vendor,
void pci_dev_init(struct device *dev);
unsigned int pci_match_simple_dev(device_t dev, pci_devfn_t sdev);
-const char * pin_to_str(int pin);
+const char *pin_to_str(int pin);
int get_pci_irq_pins(device_t dev, device_t *parent_bdg);
void pci_assign_irqs(unsigned int bus, unsigned int slot,
const unsigned char pIntAtoD[4]);
diff --git a/src/include/device/resource.h b/src/include/device/resource.h
index 947bcdd..7791e70 100644
--- a/src/include/device/resource.h
+++ b/src/include/device/resource.h
@@ -37,7 +37,7 @@ struct resource {
resource_t base; /* Base address of the resource */
resource_t size; /* Size of the resource */
resource_t limit; /* Largest valid value base + size -1 */
- ROMSTAGE_CONST struct resource* next; /* Next resource in the list */
+ ROMSTAGE_CONST struct resource *next; /* Next resource in the list */
unsigned long flags; /* Descriptions of the kind of resource */
unsigned long index; /* Bus specific per device resource id */
unsigned char align; /* Required alignment (log 2) of the resource */
@@ -56,13 +56,13 @@ struct resource {
/* Generic resource helper functions */
struct device;
struct bus;
-extern void compact_resources(struct device * dev);
+extern void compact_resources(struct device *dev);
extern struct resource *probe_resource(struct device *dev, unsigned int index);
-extern struct resource *new_resource(struct device * dev, unsigned int index);
-extern struct resource *find_resource(struct device * dev, unsigned int index);
+extern struct resource *new_resource(struct device *dev, unsigned int index);
+extern struct resource *find_resource(struct device *dev, unsigned int index);
extern resource_t resource_end(struct resource *resource);
extern resource_t resource_max(struct resource *resource);
-extern void report_resource_stored(struct device * dev, struct resource *resource, const char *comment);
+extern void report_resource_stored(struct device *dev, struct resource *resource, const char *comment);
typedef void (*resource_search_t)(void *gp, struct device *dev, struct resource *res);
extern void search_bus_resources(struct bus *bus,
diff --git a/src/include/string.h b/src/include/string.h
index d547e49..a000e6c 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -16,7 +16,7 @@ void *memset(void *s, int c, size_t n);
int memcmp(const void *s1, const void *s2, size_t n);
void *memchr(const void *s, int c, size_t n);
#if !defined(__ROMCC__)
-int snprintf(char * buf, size_t size, const char *fmt, ...);
+int snprintf(char *buf, size_t size, const char *fmt, ...);
#endif
// simple string functions
More information about the coreboot-gerrit
mailing list