[coreboot-gerrit] Patch set updated for coreboot: [Needs Test]nb/intel/i945: Programm proper ODT values

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Sun Mar 12 16:50:53 CET 2017


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18548

-gerrit

commit 6e7254cb05ddb34eb910977fb56f1fafd92c9c60
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Thu Mar 2 19:55:44 2017 +0100

    [Needs Test]nb/intel/i945: Programm proper ODT values
    
    Programm proper C1ODT value for 2nd channel
    
    Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/northbridge/intel/i945/raminit.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index a7ccefb..7733a6b 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -2801,11 +2801,17 @@ static void sdram_on_die_termination(struct sys_info *sysinfo)
 
 	if ( !(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED &&
 			sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED) ) {
-		printk(BIOS_DEBUG, "one dimm per channel config..\n");
+		printk(BIOS_DEBUG, "Channel 0 have one DIMM config..\n");
 
 		reg32 = MCHBAR32(C0ODT);
 		reg32 &= ~(7 << 28);
 		MCHBAR32(C0ODT) = reg32;
+	}
+
+	if ( !(sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED &&
+			sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED) ) {
+		printk(BIOS_DEBUG, "Channel 1 have one DIMM config..\n");
+
 		reg32 = MCHBAR32(C1ODT);
 		reg32 &= ~(7 << 28);
 		MCHBAR32(C1ODT) = reg32;



More information about the coreboot-gerrit mailing list