[coreboot-gerrit] New patch to review for coreboot: AMD geode: Avoid conflicting mainboard_romstage_entry() declaration

Marc Jones (marc@marcjonesconsulting.com) gerrit at coreboot.org
Sun Mar 12 01:30:56 CET 2017


Marc Jones (marc at marcjonesconsulting.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18769

-gerrit

commit 59e5700f96b979c6331237b83bbd9441b0b9ce68
Author: Marc Jones <marcj303 at gmail.com>
Date:   Sat Mar 11 16:28:38 2017 -0700

    AMD geode: Avoid conflicting mainboard_romstage_entry() declaration
    
    Different romstages may have different mainboard_romstage_entry()
    requirements. Only include it based on the geode silicon.
    
    Note:
    The definition would normally be in a silicon specific
    romstage.h and not in include/cpu/amd/car.h, but geode doesn't
    have a common romstage.
    
    Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
    Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
 src/include/cpu/amd/car.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/include/cpu/amd/car.h b/src/include/cpu/amd/car.h
index a9c9aa0..5c6a869 100644
--- a/src/include/cpu/amd/car.h
+++ b/src/include/cpu/amd/car.h
@@ -3,7 +3,9 @@
 
 #include <arch/cpu.h>
 
+#if CONFIG_CPU_AMD_GEODE_LX || CONFIG_CPU_AMD_GEODE_GX2
 void asmlinkage mainboard_romstage_entry(unsigned long bist);
+#endif
 
 void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx);
 void done_cache_as_ram_main(void);



More information about the coreboot-gerrit mailing list