[coreboot-gerrit] New patch to review for coreboot: src/lib: Move asmlinkage before type

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Sat Mar 11 03:28:31 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18760

-gerrit

commit 61c9926ec37b973008cfe98ae3fd5dea35ca9393
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Mar 10 15:42:55 2017 -0800

    src/lib: Move asmlinkage before type
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: storage class should be at the beginning of the declaration
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I7d3135466634a4bb84dcef16dbd68754f8d8d6c2
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/lib/bootblock.c | 2 +-
 src/lib/gcc.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c
index a560152..b859e1e 100644
--- a/src/lib/bootblock.c
+++ b/src/lib/bootblock.c
@@ -30,7 +30,7 @@ __attribute__((weak)) void bootblock_soc_early_init(void) { /* do nothing */ }
 __attribute__((weak)) void bootblock_soc_init(void) { /* do nothing */ }
 __attribute__((weak)) void bootblock_mainboard_init(void) { /* do nothing */ }
 
-void asmlinkage bootblock_main_with_timestamp(uint64_t base_timestamp)
+asmlinkage void bootblock_main_with_timestamp(uint64_t base_timestamp)
 {
 	/* Initialize timestamps if we have TIMESTAMP region in memlayout.ld. */
 	if (IS_ENABLED(CONFIG_COLLECT_TIMESTAMPS) && _timestamp_size > 0)
diff --git a/src/lib/gcc.c b/src/lib/gcc.c
index a576a77..5a93f45 100644
--- a/src/lib/gcc.c
+++ b/src/lib/gcc.c
@@ -25,7 +25,7 @@
  * specific implementations may vary
  */
 #define WRAP_LIBGCC_CALL(type, name) \
-	type __real_##name(type a, type b) asmlinkage; \
+	asmlinkage type __real_##name(type a, type b); \
 	type __wrap_##name(type a, type b); \
 	type __wrap_##name(type a, type b) { return __real_##name(a, b); }
 



More information about the coreboot-gerrit mailing list