[coreboot-gerrit] Patch merged into coreboot/master: src/include: Add parenthesis around macros

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit f00e446e746da54b7cf967deae73cf090f3835eb
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Mar 7 13:17:49 2017 -0800

    src/include: Add parenthesis around macros
    
    Fix the following error found by checkpatch.pl:
    
    ERROR: Macros with complex values should be enclosed in parentheses
    
    False positives are detected for attribute macros.  An example is:
    
    ERROR: Macros with complex values should be enclosed in parentheses
    +#define BOOT_STATE_INIT_ATTR  __attribute__ ((used, section
    (".bs_init")))
    
    False positive also generated for macros for linker script files.  An
    example is:
    
    ERROR: Macros with complex values should be enclosed in parentheses
    +#define CBFS_CACHE(addr, size) \
    +	REGION(cbfs_cache, addr, size, 4) \
    +	ALIAS_REGION(cbfs_cache, preram_cbfs_cache) \
    +	ALIAS_REGION(cbfs_cache, postram_cbfs_cache)
    
    False positives generated for assembly code macros.  An example is:
    
    ERROR: Macros with complex values should be enclosed in parentheses
    +#define DECLARE_OPTIONAL_REGION(name) asm (".weak _" #name ", _e" #name
    )
    
    False positive detected when macro includes multiple comma separated
    values.  The following code is from src/include/device/azalia_device.h:
    
    #define AZALIA_SUBVENDOR(codec, val)		    \
    	(((codec) << 28) | (0x01720 << 8) | ((val) & 0xff)),	\
    	(((codec) << 28) | (0x01721 << 8) | (((val) >> 8) & 0xff)), \
    	(((codec) << 28) | (0x01722 << 8) | (((val) >> 16) & 0xff)), \
    	(((codec) << 28) | (0x01723 << 8) | (((val) >> 24) & 0xff))
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I6e3b6950738e6906851a172ba3a22e3d5af1e35d
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/18649
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/18649 for details.

-gerrit