[coreboot-gerrit] New patch to review for coreboot: google/poppy: Enable internal pull-up on PWRBTN#

Shobhit Srivastava (shobhit.srivastava@intel.com) gerrit at coreboot.org
Fri Mar 10 08:04:48 CET 2017


Shobhit Srivastava (shobhit.srivastava at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18734

-gerrit

commit 12c96a216fd271c76b62abddb6ce35da68d32196
Author: Shobhit Srivastava <shobhit.srivastava at intel.com>
Date:   Fri Mar 10 12:23:22 2017 +0530

    google/poppy: Enable internal pull-up on PWRBTN#
    
    Enable an internal pull-up on the power button input as short
    press is resulting in power button override being asserted.
    
    BUG=b:36111214
    BRANCH=none
    TEST=tested on poppy board to ensure quick power button press does
    not result in a shutdown due to power button override.
    
    Change-Id: I3a25b78562e2302b6f7575e64c87ae8142690701
    Signed-off-by: Shobhit Srivastava <shobhit.srivastava at intel.com>
---
 src/mainboard/google/poppy/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/poppy/gpio.h b/src/mainboard/google/poppy/gpio.h
index 7ca1ba3..e83ff81 100644
--- a/src/mainboard/google/poppy/gpio.h
+++ b/src/mainboard/google/poppy/gpio.h
@@ -215,7 +215,7 @@ static const struct pad_config gpio_table[] = {
 /* BATLOW# */		PAD_CFG_NF(GPD0, NONE, DEEP, NF1),
 /* ACPRESENT */		PAD_CFG_NF(GPD1, NONE, DEEP, NF1),
 /* LAN_WAKE# */		PAD_CFG_NF(GPD2, NONE, DEEP, NF1), /* EC_PCH_WAKE_L */
-/* PWRBTN# */		PAD_CFG_NF(GPD3, NONE, DEEP, NF1),
+/* PWRBTN# */		PAD_CFG_NF(GPD3, 20K_PU, DEEP, NF1),
 /* SLP_S3# */		PAD_CFG_NF(GPD4, NONE, DEEP, NF1),
 /* SLP_S4# */		PAD_CFG_NF(GPD5, NONE, DEEP, NF1),
 /* SLP_A# */		PAD_CFG_NC(GPD6), /* TP26 */



More information about the coreboot-gerrit mailing list