[coreboot-gerrit] Patch set updated for coreboot: [NOTFORMERGE] AGESA f15tn f16kb: Revert invd to wbinvd change

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Mar 9 19:11:40 CET 2017


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18632

-gerrit

commit 87613c4b4d0feb4f2da6c0f19b0bc591053309b9
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Mar 1 13:11:45 2017 +0200

    [NOTFORMERGE] AGESA f15tn f16kb: Revert invd to wbinvd change
    
    Do not submit while any AGESA_LEGACY board in the tree,
    requires AMD_DISABLE_STACK is called with empty stack.
    
    Change-Id: If750766cc7a9ecca4641a8f14e1ab15e9abb7ff5
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/vendorcode/amd/agesa/f15tn/gcccar.inc | 2 +-
 src/vendorcode/amd/agesa/f16kb/gcccar.inc | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f15tn/gcccar.inc b/src/vendorcode/amd/agesa/f15tn/gcccar.inc
index 1701a21..7c16f7a 100644
--- a/src/vendorcode/amd/agesa/f15tn/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f15tn/gcccar.inc
@@ -1245,7 +1245,7 @@ fam15_disable_stack_remote_read_exit:
     _RDMSR
     btr     $INVD_WBINVD, %eax            # Disable INVD -> WBINVD conversion
     _WRMSR
-    wbinvd                                # Clear the cache tag RAMs
+    invd                                  # Clear the cache tag RAMs
     #.if (bh == 01h) || (bh == 03h)      ; Is this TN or KM?
     cmp   $01, %bh
     jz    4f
diff --git a/src/vendorcode/amd/agesa/f16kb/gcccar.inc b/src/vendorcode/amd/agesa/f16kb/gcccar.inc
index 87e6090..6d3f4d1 100644
--- a/src/vendorcode/amd/agesa/f16kb/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f16kb/gcccar.inc
@@ -597,8 +597,7 @@ fam16_disable_stack_remote_read_exit:
     _RDMSR
     btr     $INVD_WBINVD, %eax            # Disable INVD -> WBINVD conversion
     _WRMSR
-    wbinvd                                # Clear the cache tag RAMs
-    #invd
+    invd                                # Clear the cache tag RAMs
 
     #Do Standard Family 16 work
     mov     $HWCR, %ecx                    # MSR:C001_0015h



More information about the coreboot-gerrit mailing list