[coreboot-gerrit] Patch merged into coreboot/master: AGESA: Fix SSE regression and align stack early

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 9 12:42:59 CET 2017


the following patch was just integrated into master:
commit 26929bd71af443ae2a7080a6bd2bd9b8054a362c
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Nov 23 20:40:53 2016 +0200

    AGESA: Fix SSE regression and align stack early
    
    When allowing use of SSE instructions, stack must be
    aligned to 16 bytes. Adjust x86 entry to C accordingly,
    by pushing values to maintain the alignment.
    
    Fixes regression with new toolchain using GCC-6.3 and
      ec0a393 console: Enable printk for ENV_LIBAGESA
    
    For some builds, the above-mentioned commit emitted
    SSE instruction 'andps (%esp),%xmm0' with incorrectly
    aligned esp, raising exception and thus preventing boot.
    
    Change-Id: Ief57a2ea053c7497d50903838310b7f7800bff26
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: https://review.coreboot.org/18622
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Nico Huber <nico.h at gmx.de>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/18622 for details.

-gerrit



More information about the coreboot-gerrit mailing list