[coreboot-gerrit] New patch to review for coreboot: src/include: Remove use of binary constants

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Wed Mar 8 20:06:34 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18685

-gerrit

commit c1b5f42cc222430775a6b46ce657cc342b92bac6
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Wed Mar 8 10:11:37 2017 -0800

    src/include: Remove use of binary constants
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: Avoid gcc v4.3+ binary constant extension: <...>
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: Iab29c494060df3f60eff5317259e0fdbfea06f27
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/include/device/azalia.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/include/device/azalia.h b/src/include/device/azalia.h
index 0ac4fcd..7abf8e8 100644
--- a/src/include/device/azalia.h
+++ b/src/include/device/azalia.h
@@ -25,10 +25,10 @@
  */
 
 enum AzaliaPinCfgPortConnectivity {
-	AZALIA_PINCFG_PORT_JACK                = 0b00,
-	AZALIA_PINCFG_PORT_NC                  = 0b01,
-	AZALIA_PINCFG_PORT_FIXED               = 0b10,
-	AZALIA_PINCFG_PORT_MULTIPLE            = 0b11,
+	AZALIA_PINCFG_PORT_JACK                = 0,
+	AZALIA_PINCFG_PORT_NC                  = 1,
+	AZALIA_PINCFG_PORT_FIXED               = 2,
+	AZALIA_PINCFG_PORT_MULTIPLE            = 3,
 };
 
 enum AzaliaPinCfgLocationGross {



More information about the coreboot-gerrit mailing list