[coreboot-gerrit] Patch set updated for coreboot: src/include: Remove braces for single statements
Lee Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Wed Mar 8 20:06:21 CET 2017
Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18654
-gerrit
commit f5023b6db3d8e8c596d44642b07bdfd40aef73c1
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Tue Mar 7 15:17:04 2017 -0800
src/include: Remove braces for single statements
Fix the following warning detected by checkpatch.pl:
WARNING: braces {} are not necessary for single statement blocks
TEST=Build and run on Galileo Gen2
Change-Id: I00b59f6a27c3acb393deaa763596363b7e958efd
Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
src/include/cpu/amd/model_fxx_rev.h | 6 ++----
src/include/device/pci.h | 3 +--
src/include/pc80/mc146818rtc.h | 6 ++----
src/include/string.h | 6 ++----
4 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/src/include/cpu/amd/model_fxx_rev.h b/src/include/cpu/amd/model_fxx_rev.h
index e34b4ed..210a652 100644
--- a/src/include/cpu/amd/model_fxx_rev.h
+++ b/src/include/cpu/amd/model_fxx_rev.h
@@ -74,9 +74,8 @@ static inline int is_e0_later_in_bsp(int nodeid)
return 1;
// we don't need to do that for node 0 in core0/node0
- if (nodeid == 0) {
+ if (nodeid == 0)
return !is_cpu_pre_e0();
- }
// d0 will be treated as e0 with this methods, but the d0 nb_cfg_54 always 0
pci_devfn_t dev;
@@ -89,9 +88,8 @@ static inline int is_e0_later_in_bsp(int nodeid)
e0_later = !!(val & (1<<3));
// pre_e0 bit 3 always be 0 and can not be changed
- if (e0_later) {
+ if (e0_later)
pci_write_config32(dev, 0x80, val_old); // restore it
- }
return e0_later;
}
diff --git a/src/include/device/pci.h b/src/include/device/pci.h
index 13d63d4..e18a09a 100644
--- a/src/include/device/pci.h
+++ b/src/include/device/pci.h
@@ -103,9 +103,8 @@ static inline const struct pci_operations *ops_pci(device_t dev)
{
const struct pci_operations *pops;
pops = 0;
- if (dev && dev->ops) {
+ if (dev && dev->ops)
pops = dev->ops->ops_pci;
- }
return pops;
}
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index 39f58d6..be90358 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -140,14 +140,12 @@ static inline void cmos_write(unsigned char val, unsigned char addr)
* eg. the Century / AltCentury byte. So to be safe, disable
* RTC before changing any value.
*/
- if ((addr != RTC_CONTROL) && !(control_state & RTC_SET)) {
+ if ((addr != RTC_CONTROL) && !(control_state & RTC_SET))
cmos_write_inner(control_state | RTC_SET, RTC_CONTROL);
- }
cmos_write_inner(val, addr);
/* reset to prior configuration */
- if ((addr != RTC_CONTROL) && !(control_state & RTC_SET)) {
+ if ((addr != RTC_CONTROL) && !(control_state & RTC_SET))
cmos_write_inner(control_state, RTC_CONTROL);
- }
}
static inline void cmos_disable_rtc(void)
diff --git a/src/include/string.h b/src/include/string.h
index f2777a9..d547e49 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -24,18 +24,16 @@ int snprintf(char * buf, size_t size, const char *fmt, ...);
static inline size_t strnlen(const char *src, size_t max)
{
size_t i = 0;
- while ((*src++) && (i < max)) {
+ while ((*src++) && (i < max))
i++;
- }
return i;
}
static inline size_t strlen(const char *src)
{
size_t i = 0;
- while (*src++) {
+ while (*src++)
i++;
- }
return i;
}
More information about the coreboot-gerrit
mailing list