[coreboot-gerrit] New patch to review for coreboot: cbfstool: Remove unnecessary assignment
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Wed Mar 8 10:54:03 CET 2017
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18667
-gerrit
commit 708641458f7aa8c024dde7f4989cde01b850d8c2
Author: Paul Menzel <pmenzel at molgen.mpg.de>
Date: Wed Mar 8 10:51:52 2017 +0100
cbfstool: Remove unnecessary assignment
Fix the warning below.
```
util/cbfstool/ifwitool.c:551:2: warning: Value stored to 'offset' is never read
offset = read_member(data, offset, sizeof(h->fit_tool_version),
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Found-by: scan-build from clang 3.8.1
Change-Id: I6c322a335a371a20561b32e04e7dcc7310dab607
Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
---
util/cbfstool/ifwitool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/cbfstool/ifwitool.c b/util/cbfstool/ifwitool.c
index f6ca2a8..07eefe7 100644
--- a/util/cbfstool/ifwitool.c
+++ b/util/cbfstool/ifwitool.c
@@ -548,7 +548,7 @@ static void bpdt_read_header(void *data, struct bpdt_header *h,
&h->xor_redundant_block);
offset = read_member(data, offset, sizeof(h->ifwi_version),
&h->ifwi_version);
- offset = read_member(data, offset, sizeof(h->fit_tool_version),
+ read_member(data, offset, sizeof(h->fit_tool_version),
&h->fit_tool_version);
bpdt_validate_header(h, name);
More information about the coreboot-gerrit
mailing list