[coreboot-gerrit] Patch set updated for coreboot: AGESA: Log if memory training result cannot be stored

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18534

-gerrit

commit 40fb871d7277b2b2fe84639999f2a8954a379cfb
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Nov 26 16:15:09 2016 +0200

    AGESA: Log if memory training result cannot be stored
    
    A problem around CAR teardown time may result with missing
    training results at the time we want to save them.
    
    Record this in the logs for debugging purposes, it will
    not be possible to use S3 suspend if this happens.
    
    Change-Id: Id2ba8facbd5d90fe3ed9c6900628309c226c2454
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/amd/agesa/oem_s3.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/northbridge/amd/agesa/oem_s3.c b/src/northbridge/amd/agesa/oem_s3.c
index a9504ac..8ffebc9 100644
--- a/src/northbridge/amd/agesa/oem_s3.c
+++ b/src/northbridge/amd/agesa/oem_s3.c
@@ -126,6 +126,11 @@ AGESA_STATUS OemS3Save(AMD_S3SAVE_PARAMS *S3SaveParams)
 	if (size && dataBlock->NvStorageSize)
 		spi_SaveS3info(pos, size, dataBlock->NvStorage,
 			dataBlock->NvStorageSize);
+	else
+		printk(BIOS_EMERG,
+			"Error: Cannot store memory training results in SPI.\n"
+			"Error: S3 resume will not be possible.\n"
+		);
 
 	/* To be consumed in AmdS3LateRestore. */
 	char *heap = cbmem_add(CBMEM_ID_RESUME_SCRATCH, HIGH_MEMORY_SCRATCH);