[coreboot-gerrit] Patch set updated for coreboot: ec/lenovo/h8: Use older syntax for bit shift

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Mar 6 11:38:05 CET 2017


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18520

-gerrit

commit 78e2efce6909bd53d465aa3bab65832f0e740ce1
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Feb 28 20:23:37 2017 +0100

    ec/lenovo/h8: Use older syntax for bit shift
    
    Currently, when using `iasl` 20140926-32 [Oct  1 2014] from Debian 8
    (Jessie/stable), the build of the Lenovo X60 fails due to syntax errors.
    
    ASL 2.0 supports `<<`. For consistency, right now, coreboot still uses
    the old syntax. So use `ShiftLeft` instead, which also fixes the build
    issue with older ASL compilers.
    
    Change-Id: Id7e309c31612387da3920cf7d846b358ac2bdc71
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/ec/lenovo/h8/acpi/ec.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index b8350ad..ed62afe 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -363,7 +363,7 @@ Device(EC)
 		/* Report tablet mode switch state */
 		Method (MHKG, 0, NotSerialized)
 		{
-			Return (TBSW << 3)
+			Return (ShiftLeft(TBSW, 3))
 		}
 		/* Mute audio */
 		Method (SSMS, 1, NotSerialized)



More information about the coreboot-gerrit mailing list