[coreboot-gerrit] New patch to review for coreboot: [NOTFORMERGE] AGESA binaryPI: Flip HUDSON_IMC_FWM default to disabled

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sat Mar 4 10:25:49 CET 2017


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18561

-gerrit

commit c5c5454673f4700753e30cddff60bd5333412568
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Mar 4 11:15:02 2017 +0200

    [NOTFORMERGE] AGESA binaryPI: Flip HUDSON_IMC_FWM default to disabled
    
    TODO: Figure out for which boards it can be selected in
    the first place. Hardware dependency if it can work at all.
    
    Change-Id: I87146e32e1a9a8f8133987d2b26e059065c89b14
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/southbridge/amd/agesa/hudson/Kconfig | 4 +++-
 src/southbridge/amd/pi/hudson/Kconfig    | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index 91ebe03..d958827 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -63,7 +63,9 @@ config HUDSON_XHCI_FWM
 
 config HUDSON_IMC_FWM
 	bool "Add imc firmware"
-	default y if USE_BLOBS
+	default n
+	depends on !HUDSON_DISABLE_IMC
+	depends on USE_BLOBS
 	select SPI_FLASH_HAS_VOLATILE_GROUP if SPI_FLASH
 	help
 	  Add Hudson 2/3/4 IMC Firmware to support the onboard fan control
diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig
index f6e3355..bcd6e4f 100644
--- a/src/southbridge/amd/pi/hudson/Kconfig
+++ b/src/southbridge/amd/pi/hudson/Kconfig
@@ -66,8 +66,10 @@ config HUDSON_XHCI_FWM
 
 config HUDSON_IMC_FWM
 	bool "Add IMC firmware"
+	default n
 	depends on !HUDSON_DISABLE_IMC
-	default y
+	depends on USE_BLOBS
+	select SPI_FLASH_HAS_VOLATILE_GROUP if SPI_FLASH
 	help
 	  Add Hudson 2/3/4 IMC Firmware to support the onboard fan control
 



More information about the coreboot-gerrit mailing list