[coreboot-gerrit] New patch to review for coreboot: lint: Remove signed-off-by check

Zheng Bao (fishbaozi@gmail.com) gerrit at coreboot.org
Wed Mar 1 07:02:03 CET 2017


Zheng Bao (fishbaozi at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18524

-gerrit

commit 8968751094ee61cbea707f0338f464e92d259cb4
Author: Zheng Bao <fishbaozi at gmail.com>
Date:   Wed Mar 1 13:56:25 2017 +0800

    lint: Remove signed-off-by check
    
    The command "git log -n 1" only gets the last commit message,
    instead of this time.
    Pre-commit in git,
    "It takes no parameters, and is invoked before obtaining the
    proposed commit log message and making a commit."
    Only commit-msg can handle the message.
    
    Change-Id: I01208ae984915142521da541b81eecd288be7e19
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 util/lint/lint-stable-020-signed-off-by | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/util/lint/lint-stable-020-signed-off-by b/util/lint/lint-stable-020-signed-off-by
deleted file mode 100755
index 40b6e9e..0000000
--- a/util/lint/lint-stable-020-signed-off-by
+++ /dev/null
@@ -1,23 +0,0 @@
-#!/bin/sh
-# This file is part of the coreboot project.
-#
-# Copyright 2016 Google Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; version 2 of the License, or (at your option)
-# any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# DESCR: Check for a signed-off-by line on the latest git commit
-
-# This test is mainly for the jenkins server
-if [ -n "$(command -v git)" ] && [ -d .git ]; then
-	if [ -z "$(git log -n 1 | grep '[[:space:]]\+Signed-off-by: ')" ]; then
-		echo "No Signed-off-by line in commit message"
-	fi
-fi



More information about the coreboot-gerrit mailing list