[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Interrupt changes for audio devices

Duncan Laurie (Code Review) gerrit at coreboot.org
Fri Jun 30 11:11:45 CEST 2017


Duncan Laurie has uploaded a new patch set (#2). ( https://review.coreboot.org/20433 )

Change subject: mb/google/eve: Interrupt changes for audio devices
......................................................................

mb/google/eve: Interrupt changes for audio devices

Use the new PAD_CFG_GPI_INT macro to specify the headset codec
interrupt as specifically edge triggered (since it is registered
as EDGE_BOTH in the devicetree) in order to prevent the interrupt
from firing unexpectedly when the system is resuming.

Also change the DSP interrupt to edge triggered since the kernel
is registering with IRQF_TRIGGER_RISING in order to prevent an
interrupt storm when it asserts.

BUG=b:35582164
TEST=manual testing on Eve:
1) ensure the headset codec sends interrupt on insert and remove
2) ensure there is only one interrupt counted when DSP asserts irq

Change-Id: I40a8ee667de653e4e70770cd96b6417442c1b0ec
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/devicetree.cb
M src/mainboard/google/eve/gpio.h
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/20433/2
-- 
To view, visit https://review.coreboot.org/20433
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I40a8ee667de653e4e70770cd96b6417442c1b0ec
Gerrit-Change-Number: 20433
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170630/2b0214b4/attachment.html>


More information about the coreboot-gerrit mailing list