[coreboot-gerrit] Change in coreboot[master]: siemens/nc_fpga: Rename freeze_mode to freeze_disable

Werner Zeh (Code Review) gerrit at coreboot.org
Fri Jun 30 10:42:09 CEST 2017


Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20432


Change subject: siemens/nc_fpga: Rename freeze_mode to freeze_disable
......................................................................

siemens/nc_fpga: Rename freeze_mode to freeze_disable

The flag FF_FreezeDis marks if this feature is disabled. For a better
readability rename freeze_mode to freeze_disable and invert the meaning
of this information.

Change-Id: I648b2392d2c8046965479511fde485a9cb934378
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/drivers/siemens/nc_fpga/nc_fpga.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/20432/1

diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c
index 59e7d4b..8fb25bc 100644
--- a/src/drivers/siemens/nc_fpga/nc_fpga.c
+++ b/src/drivers/siemens/nc_fpga/nc_fpga.c
@@ -58,7 +58,7 @@
 
 static void init_fan_ctrl (void *base_adr)
 {
-	uint8_t mask = 0, freeze_mode = 0, fan_req = 0;
+	uint8_t mask = 0, freeze_disable = 0, fan_req = 0;
 	volatile fan_ctrl_t *ctrl = (fan_ctrl_t *)base_adr;
 
 	/* Program all needed fields of FAN controller. */
@@ -76,10 +76,10 @@
 	FPGA_SET_PARAM(FANMaxSpeed, ctrl->fanmax);
 	/* Set freeze and FAN configuration. */
 	if ((hwilib_get_field(FF_FanReq, &fan_req, 1) == 1) &&
-	    (hwilib_get_field(FF_FreezeDis, &freeze_mode, 1) == 1)) {
+	    (hwilib_get_field(FF_FreezeDis, &freeze_disable, 1) == 1)) {
 		if (!fan_req)
 			mask = 1;
-		else if  (fan_req && freeze_mode)
+		else if  (fan_req && !freeze_disable)
 			mask = 2;
 		else
 			mask = 3;

-- 
To view, visit https://review.coreboot.org/20432
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I648b2392d2c8046965479511fde485a9cb934378
Gerrit-Change-Number: 20432
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170630/113d634b/attachment.html>


More information about the coreboot-gerrit mailing list