[coreboot-gerrit] Change in coreboot[master]: vendorcode/siemens: Fix bug in hwilib for FF_FanReq and FF_F...

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20431


Change subject: vendorcode/siemens: Fix bug in hwilib for FF_FanReq and FF_FreezeDis
......................................................................

vendorcode/siemens: Fix bug in hwilib for FF_FanReq and FF_FreezeDis

The two flags FF_FanReq and FF_Freeze_Dis should be treated as
8 bit values and not as 32 bit. Change the length of these fields to
1 byte and adjust the offset and mask for FF_FanReq.

Change-Id: If5e9e8b16491a33997cc39c3dd9b80f97682adc6
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/vendorcode/siemens/hwilib/hwilib.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/20431/1

diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c
index c1533e8..08e8da9 100644
--- a/src/vendorcode/siemens/hwilib/hwilib.c
+++ b/src/vendorcode/siemens/hwilib/hwilib.c
@@ -143,14 +143,14 @@
 		.pos[0] = {.blk_type = BLK_HIB, .offset = 0xe0, .len = 0x80},
 		.get_field = hwilib_read_bytes },
 	[FF_FreezeDis] = {
-		.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4},
+		.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 1},
 		.mask = 0x10,
 		.mask_offset = 4,
 		.get_field = hwilib_read_bytes },
 	[FF_FanReq] = {
-		.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4},
-		.mask = 0x400,
-		.mask_offset = 10,
+		.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b9, .len = 1},
+		.mask = 0x04,
+		.mask_offset = 2,
 		.get_field = hwilib_read_bytes },
 	[NvramVirtTimeDsaveReset] = {
 		.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1be, .len = 2},

-- 
To view, visit https://review.coreboot.org/20431
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5e9e8b16491a33997cc39c3dd9b80f97682adc6
Gerrit-Change-Number: 20431
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170630/de8b75aa/attachment.html>