[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: Do not limit memory speed on new SKU 5 boards

Duncan Laurie (Code Review) gerrit at coreboot.org
Fri Jun 30 09:06:48 CEST 2017


Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/20429


Change subject: mb/google/eve: Do not limit memory speed on new SKU 5 boards
......................................................................

mb/google/eve: Do not limit memory speed on new SKU 5 boards

Board changes in rev6+ have a fix to VDDQ that should fix the issue
that was being seen with this SKU, so only lower the memory speed on
older boards.

BUG=b:37172778
TEST=memory stress testing on rev6 boards

Change-Id: I6d6fe730cabd74af23eab3f02feef9da01a35fd4
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/romstage.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/20429/1

diff --git a/src/mainboard/google/eve/romstage.c b/src/mainboard/google/eve/romstage.c
index cd8fa08..6f8ff0f 100644
--- a/src/mainboard/google/eve/romstage.c
+++ b/src/mainboard/google/eve/romstage.c
@@ -14,6 +14,7 @@
  * GNU General Public License for more details.
  */
 
+#include <boardid.h>
 #include <string.h>
 #include <stddef.h>
 #include <fsp/soc_binding.h>
@@ -49,7 +50,7 @@
 	mem_cfg->MemorySpdDataLen = SPD_LEN;
 
 	/* Limit K4EBE304EB-EGCF memory to 1600MHz for stability */
-	if (mainboard_get_spd_index() == 5) {
+	if (board_id() < 6 && mainboard_get_spd_index() == 5) {
 		printk(BIOS_WARNING, "Limiting memory to 1600MHz\n");
 		mem_cfg->DdrFreqLimit = 1600;
 	}

-- 
To view, visit https://review.coreboot.org/20429
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d6fe730cabd74af23eab3f02feef9da01a35fd4
Gerrit-Change-Number: 20429
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170630/7ff123d6/attachment.html>


More information about the coreboot-gerrit mailing list