[coreboot-gerrit] Change in coreboot[master]: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets...

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Mon Jun 26 21:31:47 CEST 2017


HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20371


Change subject: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro
......................................................................

payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro

Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M payloads/libpayload/drivers/usb/xhci_private.h
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20371/1

diff --git a/payloads/libpayload/drivers/usb/xhci_private.h b/payloads/libpayload/drivers/usb/xhci_private.h
index 47a464f..3b4e7bb 100644
--- a/payloads/libpayload/drivers/usb/xhci_private.h
+++ b/payloads/libpayload/drivers/usb/xhci_private.h
@@ -387,25 +387,25 @@
 	   making bitfields unusable for MMIO register blocks. Yay C :-( */
 	volatile struct opreg {
 		u32 usbcmd;
-#define USBCMD_RS 1<<0
-#define USBCMD_HCRST 1<<1
-#define USBCMD_INTE 1<<2
+#define USBCMD_RS (1 << 0)
+#define USBCMD_HCRST (1 << 1)
+#define USBCMD_INTE (1 << 2)
 		u32 usbsts;
-#define USBSTS_HCH 1<<0
-#define USBSTS_HSE 1<<2
-#define USBSTS_EINT 1<<3
-#define USBSTS_PCD 1<<4
-#define USBSTS_CNR 1<<11
+#define USBSTS_HCH (1 << 0)
+#define USBSTS_HSE (1 << 2)
+#define USBSTS_EINT (1 << 3)
+#define USBSTS_PCD (1 << 4)
+#define USBSTS_CNR (1 << 11)
 #define USBSTS_PRSRV_MASK ((1 << 1) | 0xffffe000)
 		u32 pagesize;
 		u8 res1[0x13-0x0c+1];
 		u32 dnctrl;
 		u32 crcr_lo;
 		u32 crcr_hi;
-#define CRCR_RCS 1<<0
-#define CRCR_CS 1<<1
-#define CRCR_CA 1<<2
-#define CRCR_CRR 1<<3
+#define CRCR_RCS (1 << 0)
+#define CRCR_CS (1 << 1)
+#define CRCR_CA (1 << 2)
+#define CRCR_CRR (1 << 3)
 		u8 res2[0x2f-0x20+1];
 		u32 dcbaap_lo;
 		u32 dcbaap_hi;

-- 
To view, visit https://review.coreboot.org/20371
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c
Gerrit-Change-Number: 20371
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170626/883e0c98/attachment.html>


More information about the coreboot-gerrit mailing list