[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Move mainboard_ec_init to dev init phase

Marc Jones (Code Review) gerrit at coreboot.org
Fri Jun 23 07:51:41 CEST 2017


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/20312


Change subject: google/kahlee: Move mainboard_ec_init to dev init phase
......................................................................

google/kahlee: Move mainboard_ec_init to dev init phase

Move mainboard_ec_init out of mainboard chip init to the more
appropriate dev->ops->init phase.

Change-Id: Ieabcecf70e4de0b42fc639d031755b6d0b66f08a
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/mainboard/google/kahlee/mainboard.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/20312/1

diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index b5800b4..639ebbb 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -78,6 +78,11 @@
 	picr_data_ptr = mainboard_picr_data;
 }
 
+static void mainboard_init(device_t dev)
+{
+	mainboard_ec_init();
+}
+
 static int mainboard_smbios_data(device_t dev, int *handle,
 				 unsigned long *current)
 {
@@ -105,7 +110,7 @@
 	/* Initialize the PIRQ data structures for consumption */
 	pirq_setup();
 
-	mainboard_ec_init();
+	dev->ops->init = mainboard_init;
 	dev->ops->get_smbios_data = mainboard_smbios_data;
 }
 

-- 
To view, visit https://review.coreboot.org/20312
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieabcecf70e4de0b42fc639d031755b6d0b66f08a
Gerrit-Change-Number: 20312
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170623/fc58f310/attachment-0001.html>


More information about the coreboot-gerrit mailing list