[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Enable decoding for COM 3 on LPC

[Mario Scheithauer (Code Review)]

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/20295


Change subject: siemens/mc_apl1: Enable decoding for COM 3 on LPC
......................................................................

siemens/mc_apl1: Enable decoding for COM 3 on LPC

It does not work to enable the LPC range into the function
mainboard_init() because the SMBUS driver closes the range during PCI
enumeration again. For this reason, enable decoding of the address range
for COM 3 will be done at a later point in time - mainboard_final().

Change-Id: I452bca4e430b1ea75e4a327591da84500491fe84
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/mainboard.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20295/1

diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c
index 2d8a080..f077c14 100644
--- a/src/mainboard/siemens/mc_apl1/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/mainboard.c
@@ -110,9 +110,6 @@
 
 	pads = brd_gpio_table(&num);
 	gpio_configure_pads(pads, num);
-
-	/* Enable additional I/O decoding range on LPC for COM 3 */
-	lpc_open_pmio_window(0x3e8, 8);
 }
 
 static void mainboard_final(void *chip_info)
@@ -128,6 +125,9 @@
 		printk(BIOS_ERR, "LCD: Set up PTN with status 0x%x\n", status);
 	else
 		printk(BIOS_INFO, "LCD: Set up PTN was successful.\n");
+
+	/* Enable additional I/O decoding range on LPC for COM 3 */
+	lpc_open_pmio_window(0x3e8, 8);
 }
 
 struct chip_operations mainboard_ops = {

-- 
To view, visit https://review.coreboot.org/20295
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I452bca4e430b1ea75e4a327591da84500491fe84
Gerrit-Change-Number: 20295
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170621/8c480835/attachment.html>