[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/gma: Restructure code

[Philippe Mathieu-Daudé (Code Review)]

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20288 )

Change subject: nb/intel/sandybridge/gma: Restructure code
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/20288/2/src/northbridge/intel/sandybridge/gma.c
File src/northbridge/intel/sandybridge/gma.c:

https://review.coreboot.org/#/c/20288/2/src/northbridge/intel/sandybridge/gma.c@613
PS2, Line 613: 		/* This should probably run before post VBIOS init. */
can you remove this line now?



-- 
To view, visit https://review.coreboot.org/20288
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c92526a7eefd55b5ffc3bd00faa5030fe565353
Gerrit-Change-Number: 20288
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Jun 2017 18:41:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170620/331f0b25/attachment.html>