[coreboot-gerrit] Change in coreboot[master]: mainboard/asrock: add ASRock B75 Pro3-m

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20227 )

Change subject: mainboard/asrock: add ASRock B75 Pro3-m
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/early_southbridge.c
File src/mainboard/asrock/b75pro3-m/early_southbridge.c:

https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/early_southbridge.c@39
PS1, Line 39: RCBA32(0x3414) = 0x00000020;
BUC is supposed to be a 1byte reg...


https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/early_southbridge.c@40
PS1, Line 40: RCBA32(0x3418) = 0x17ce1fe1;
I think ramstage does this dynamically on sandy bridge. Maybe this is what is causing troubles with 1c.4?


https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/early_southbridge.c@79
PS1, Line 79: /* FIXME: Put proper SPD map here. */
            : void mainboard_get_spd(spd_raw_data *spd, bool id_only)
            : {
            : 	read_spd(&spd[0], 0x50, id_only);
            : 	read_spd(&spd[1], 0x51, id_only);
            : 	read_spd(&spd[2], 0x52, id_only);
            : 	read_spd(&spd[3], 0x53, id_only);
            : }
have you checked this?


https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/gnvs.c
File src/mainboard/asrock/b75pro3-m/gnvs.c:

https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/gnvs.c@1
PS1, Line 1: #include <southbridge/intel/bd82x6x/nvs.h>
license header. (I think https://review.coreboot.org/#/c/19510/ would have added it)


https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/gpio.c
File src/mainboard/asrock/b75pro3-m/gpio.c:

https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/gpio.c@1
PS1, Line 1: #include <southbridge/intel/common/gpio.h>
Could you try generating this file with https://review.coreboot.org/#/c/19508/ applied to autoport?


https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/hda_verb.c
File src/mainboard/asrock/b75pro3-m/hda_verb.c:

https://review.coreboot.org/#/c/20227/1/src/mainboard/asrock/b75pro3-m/hda_verb.c@1
PS1, Line 1: #include <device/azalia_device.h>
license header



-- 
To view, visit https://review.coreboot.org/20227
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94fbfcee06921538b32aa3c23efa642e7e405ef6
Gerrit-Change-Number: 20227
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 15 Jun 2017 20:16:51 +0000
Gerrit-HasComments: Yes