[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/opregion: Use enum cb_err as return value

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Jun 15 09:54:09 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20220 )

Change subject: soc/intel/common/opregion: Use enum cb_err as return value
......................................................................


Patch Set 1:

The 'enum cb_err' is included in "soc/intel/common/vbt.h" so it is indirectly included in the functions that use it.
Should <types.h> directly be included in the headers and linked *.c files?


-- 
To view, visit https://review.coreboot.org/20220
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib99fcfe347b98736979fc82ab3de48bfc6fc7dcd
Gerrit-Change-Number: 20220
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 15 Jun 2017 07:54:09 +0000
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list