[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add common MP Init code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/20189 )

Change subject: soc/intel/common/block: Add common MP Init code
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/20189/2/src/soc/intel/common/block/cpu/mp_init.c
File src/soc/intel/common/block/cpu/mp_init.c:

https://review.coreboot.org/#/c/20189/2/src/soc/intel/common/block/cpu/mp_init.c@65
PS2, Line 65: read_cpu_topology
anyone going to use this outside this file? if not then static else why don;t u move this code into cpu common lib?



-- 
To view, visit https://review.coreboot.org/20189
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b20d413c85bf7ec6ed89b4cdf1770c33507236b
Gerrit-Change-Number: 20189
Gerrit-PatchSet: 2
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Wed, 14 Jun 2017 09:32:24 +0000
Gerrit-HasComments: Yes