[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/common: Put PCIe space size in a Kconfig choice

Arthur Heymans (Code Review) gerrit at coreboot.org
Tue Jun 13 14:16:50 CEST 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20179


Change subject: src/soc/intel/common: Put PCIe space size in a Kconfig choice
......................................................................

src/soc/intel/common: Put PCIe space size in a Kconfig choice

Previously it looked as if you could select multiple BAR sizes at the
same time which makes no sense whatsoever.

Does this even need to be changeable in menuconfig?

Change-Id: I8b2794f56f39492589a08e5676cb33eec89a976e
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/soc/intel/common/block/systemagent/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20179/1

diff --git a/src/soc/intel/common/block/systemagent/Kconfig b/src/soc/intel/common/block/systemagent/Kconfig
index 2084a38..318c4af 100644
--- a/src/soc/intel/common/block/systemagent/Kconfig
+++ b/src/soc/intel/common/block/systemagent/Kconfig
@@ -16,6 +16,12 @@
 	help
 	  This option allows you to select length of PCIEX region.
 
+choice
+	prompt "PCIe MMIO space size"
+	default PCIEX_LENGTH_256MB
+	help
+	  This allows to select the PCIe MMIO space size
+
 config PCIEX_LENGTH_256MB
 	bool "256MB"
 
@@ -25,6 +31,8 @@
 config PCIEX_LENGTH_64MB
 	bool "64MB"
 
+endchoice
+
 config SA_ENABLE_IMR
 	bool
 	default n

-- 
To view, visit https://review.coreboot.org/20179
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b2794f56f39492589a08e5676cb33eec89a976e
Gerrit-Change-Number: 20179
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>



More information about the coreboot-gerrit mailing list