[coreboot-gerrit] Change in coreboot[master]: cbmem: Escape literal asterisks in log banner regex

Julius Werner (Code Review) gerrit at coreboot.org
Tue Jun 13 02:37:32 CEST 2017


Julius Werner has uploaded this change for review. ( https://review.coreboot.org/20171


Change subject: cbmem: Escape literal asterisks in log banner regex
......................................................................

cbmem: Escape literal asterisks in log banner regex

I had a stupid. :( Asterisks have a special meaning in regexes, but I
just wanted to match three literal ones. This kills the regex parser.

Change-Id: Ia6149e72715d651c914583ed3235680ce5b7a2e0
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M util/cbmem/cbmem.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20171/1

diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c
index daa7b56..4c1fa0e 100644
--- a/util/cbmem/cbmem.c
+++ b/util/cbmem/cbmem.c
@@ -670,7 +670,7 @@
 	cursor = 0;
 	if (one_boot_only) {
 #define BANNER_REGEX(stage) "\n\ncoreboot-[^\n]* " stage " starting\\.\\.\\.\n"
-#define OVERFLOW_REGEX(stage) "\n*** Pre-CBMEM " stage " console overflowed"
+#define OVERFLOW_REGEX(stage) "\n\\*\\*\\* Pre-CBMEM " stage " console overflow"
 		const char *regex[] = { BANNER_REGEX("bootblock"),
 					BANNER_REGEX("romstage"),
 					OVERFLOW_REGEX("romstage"),

-- 
To view, visit https://review.coreboot.org/20171
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6149e72715d651c914583ed3235680ce5b7a2e0
Gerrit-Change-Number: 20171
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>



More information about the coreboot-gerrit mailing list