[coreboot-gerrit] Change in coreboot[master]: siemens/nc_fpga: Expands the functionality of the FPGA

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/20160 )

Change subject: siemens/nc_fpga: Expands the functionality of the FPGA
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/20160/1/src/drivers/siemens/nc_fpga/nc_fpga.c
File src/drivers/siemens/nc_fpga/nc_fpga.c:

https://review.coreboot.org/#/c/20160/1/src/drivers/siemens/nc_fpga/nc_fpga.c@127
PS1, Line 127: uint8_t *bl_bn_ptr =
             : 				(uint8_t *)(bar0_ptr + NC_BL_BRIGHTNESS_OFFSET);
Keep both variable declarations on two consecutive lines.


https://review.coreboot.org/#/c/20160/1/src/drivers/siemens/nc_fpga/nc_fpga.c@145
PS1, Line 145: 0x4080,
             : 	0x4091,
             : 	0
Adjust the intend so that the values are closer to the opening curly bracket.


https://review.coreboot.org/#/c/20160/1/src/drivers/siemens/nc_fpga/nc_fpga.c@147
PS1, Line 147: ,
remove the last comma



-- 
To view, visit https://review.coreboot.org/20160
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b65b01f0d67afe598b7c005868f71b00dec56fd
Gerrit-Change-Number: 20160
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 12 Jun 2017 08:41:00 +0000
Gerrit-HasComments: Yes