[coreboot-gerrit] Change in coreboot[master]: lib/spd_bin: Print out correct SMBus SPD address in dump_spd...

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu Jun 8 22:30:31 CEST 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/20118


Change subject: lib/spd_bin: Print out correct SMBus SPD address in dump_spd_info
......................................................................

lib/spd_bin: Print out correct SMBus SPD address in dump_spd_info

With change dd82edc388 (lib/spd_bin: make SMBus SPD addresses an
input), SMBus SPD addresses are accepted from the mainboard and not
calculated within the spd_bin library routines. Use the addr_map
values to print correct address in dump_spd_info.

Change-Id: Iff37e382aeac9704f74bafc2ecb27f14c478723f
---
M src/lib/spd_bin.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/20118/1

diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c
index 3e26004..a9f6a36 100644
--- a/src/lib/spd_bin.c
+++ b/src/lib/spd_bin.c
@@ -29,7 +29,7 @@
 
 	for (i = 0; i < CONFIG_DIMM_MAX; i++)
 		if (blk->spd_array[i] != NULL && blk->spd_array[i][0] != 0) {
-			printk(BIOS_DEBUG, "SPD @ 0x%02X\n", 0xA0|(i << 1));
+			printk(BIOS_DEBUG, "SPD @ 0x%02X\n", blk->addr_map[i]);
 			print_spd_info(blk->spd_array[i]);
 		}
 }

-- 
To view, visit https://review.coreboot.org/20118
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff37e382aeac9704f74bafc2ecb27f14c478723f
Gerrit-Change-Number: 20118
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>



More information about the coreboot-gerrit mailing list