[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Use common GPIO driver

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20074 )

Change subject: soc/intel/cannonlake: Use common GPIO driver
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc/gpio_defs.h
File src/soc/intel/cannonlake/include/soc/gpio_defs.h:

https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc/gpio_defs.h@151
PS1, Line 151: #define GPP_F0_IRQ		0x0
Typo? IRQ 0 always revered for timer irq.


https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc/gpio_defs.h@199
PS1, Line 199: #define GPP_H1_IRQ			0x48
extra tab here?



-- 
To view, visit https://review.coreboot.org/20074
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbdd641244f0c7baaa2146dcfde6431bde387c5
Gerrit-Change-Number: 20074
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Jun 2017 09:18:56 +0000
Gerrit-HasComments: Yes