[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Initial set of board files

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20075 )

Change subject: mainboard/intel/cannonlake_rvp: Initial set of board files
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/20075/1/src/mainboard/intel/cannonlake_rvp/Kconfig
File src/mainboard/intel/cannonlake_rvp/Kconfig:

https://review.coreboot.org/#/c/20075/1/src/mainboard/intel/cannonlake_rvp/Kconfig@28
PS1, Line 28: bs/mainboard/$(CONFIG_MAINBOARD_DIR)/me.bin"
Do we need to add the EC_BIN here?



-- 
To view, visit https://review.coreboot.org/20075
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82bd5c785e451f02b827765c54d432517afd7de0
Gerrit-Change-Number: 20075
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Jun 2017 07:48:57 +0000
Gerrit-HasComments: Yes