[coreboot-gerrit] Change in coreboot[master]: x86/acpigen: Fix acpigen_write_field

Patrick Rudolph (Code Review) gerrit at coreboot.org
Wed Jun 7 10:27:40 CEST 2017


Hello Duncan Laurie, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/19435

to look at the new patch set (#2).

Change subject: x86/acpigen: Fix acpigen_write_field
......................................................................

x86/acpigen: Fix acpigen_write_field

The current code doesn't work for field with size > 0x3f.
Fix that by using the correct syntax, reverse engineered using
iasl.
Tested on GNU Linux 4.9 and iasl.

Change-Id: Iac3600f184e6bd36a2bcb85753110692fbcbe4b6
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/arch/x86/acpigen.c
1 file changed, 33 insertions(+), 21 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19435/2
-- 
To view, visit https://review.coreboot.org/19435
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac3600f184e6bd36a2bcb85753110692fbcbe4b6
Gerrit-Change-Number: 19435
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list