[coreboot-gerrit] Change in coreboot[master]: mb/apple/macbook21: Add ACPI C3 state

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20083


Change subject: mb/apple/macbook21: Add ACPI C3 state
......................................................................

mb/apple/macbook21: Add ACPI C3 state

This needs the clockgen to be reconfigured. Values are taken while
running vendor firmware (smbus device at offset 0x69 using smbus block
read)

Change-Id: I0b391825a0e79bddb9aa4c914153a9bac2f20155
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/apple/macbook21/devicetree.cb
M src/mainboard/apple/macbook21/mainboard.c
2 files changed, 25 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/20083/1

diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb
index b6e61eb..bc03e01 100644
--- a/src/mainboard/apple/macbook21/devicetree.cb
+++ b/src/mainboard/apple/macbook21/devicetree.cb
@@ -109,6 +109,15 @@
 			end
 			device pci 1f.3 on # SMBUS
 				subsystemid 0x8086 0x7270
+					chip drivers/i2c/ck505
+					register "nregs" = "20"
+					register "regs" = "{0x77, 0x77, 0x2d,
+						0x00, 0x21, 0x10, 0x3b, 0x06, 0x07,
+						0x0f, 0xf0, 0x01, 0x1e, 0x7f, 0x80,
+						0x80, 0x10, 0x08, 0x04, 0x01 }"
+					device i2c 69 on end
+				end
+
 			end
 		end
 	end
diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c
index eb74ec1..1e8ca8a 100644
--- a/src/mainboard/apple/macbook21/mainboard.c
+++ b/src/mainboard/apple/macbook21/mainboard.c
@@ -62,6 +62,22 @@
 			.addrh = 0,
 		}
 	},
+		{
+		.ctype = 3,
+		.latency = 1,
+		.power = 250,
+		.resource = {
+			.space_id = ACPI_ADDRESS_SPACE_FIXED,
+			.bit_width = ACPI_FFIXEDHW_VENDOR_INTEL,
+			.bit_offset = ACPI_FFIXEDHW_CLASS_MWAIT,
+			{
+				.resv = 0,
+			},
+			 /* C3 gets automatically upgraded by SB *//
+			.addrl = 0x20,
+			.addrh = 0,
+		}
+	},
 };
 
 int get_cst_entries(acpi_cstate_t **entries)

-- 
To view, visit https://review.coreboot.org/20083
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b391825a0e79bddb9aa4c914153a9bac2f20155
Gerrit-Change-Number: 20083
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>