[coreboot-gerrit] Change in coreboot[master]: spi: Remove unused/unnecessary spi_init function definitions

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/20039


Change subject: spi: Remove unused/unnecessary spi_init function definitions
......................................................................

spi: Remove unused/unnecessary spi_init function definitions

Remove spi_init definitions which:
1. Do nothing
2. Set static global variables to 0

Change-Id: If4c0cdbe2271fc7561becd87ad3b96bd45e77430
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/imgtec/pistachio/spi.c
M src/soc/qualcomm/ipq40xx/spi.c
M src/soc/qualcomm/ipq806x/spi.c
M src/soc/samsung/exynos5420/spi.c
M src/southbridge/amd/sb700/spi.c
5 files changed, 0 insertions(+), 28 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/20039/1

diff --git a/src/soc/imgtec/pistachio/spi.c b/src/soc/imgtec/pistachio/spi.c
index bfd982c..7e1a7a6 100644
--- a/src/soc/imgtec/pistachio/spi.c
+++ b/src/soc/imgtec/pistachio/spi.c
@@ -410,13 +410,6 @@
 	return SPIM_OK;
 }
 
-/* Initialization, must be called once on start up */
-void spi_init(void)
-{
-	/* Clear everything just in case */
-	memset(img_spi_slaves, 0, sizeof(img_spi_slaves));
-}
-
 /* Claim the bus and prepare it for communication */
 static int spi_ctrlr_claim_bus(const struct spi_slave *slave)
 {
diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c
index 157903c..3dc6022 100644
--- a/src/soc/qualcomm/ipq40xx/spi.c
+++ b/src/soc/qualcomm/ipq40xx/spi.c
@@ -201,12 +201,6 @@
 
 static struct ipq_spi_slave spi_slave_pool[2];
 
-void spi_init(void)
-{
-	/* just in case */
-	memset(spi_slave_pool, 0, sizeof(spi_slave_pool));
-}
-
 static struct ipq_spi_slave *to_ipq_spi(const struct spi_slave *slave)
 {
 	struct ipq_spi_slave *ds;
diff --git a/src/soc/qualcomm/ipq806x/spi.c b/src/soc/qualcomm/ipq806x/spi.c
index c20ad9a..f9a89fc 100644
--- a/src/soc/qualcomm/ipq806x/spi.c
+++ b/src/soc/qualcomm/ipq806x/spi.c
@@ -493,12 +493,6 @@
 };
 static struct ipq_spi_slave spi_slave_pool[2];
 
-void spi_init()
-{
-	/* just in case */
-	memset(spi_slave_pool, 0, sizeof(spi_slave_pool));
-}
-
 static struct ipq_spi_slave *to_ipq_spi(const struct spi_slave *slave)
 {
 	struct ipq_spi_slave *ds;
diff --git a/src/soc/samsung/exynos5420/spi.c b/src/soc/samsung/exynos5420/spi.c
index fa53c0f..2023b10 100644
--- a/src/soc/samsung/exynos5420/spi.c
+++ b/src/soc/samsung/exynos5420/spi.c
@@ -95,10 +95,6 @@
 	setbits_le32(&regs->ch_cfg, SPI_RX_CH_ON | SPI_TX_CH_ON);
 }
 
-void spi_init(void)
-{
-}
-
 static void exynos_spi_init(struct exynos_spi *regs)
 {
 	// Set FB_CLK_SEL.
diff --git a/src/southbridge/amd/sb700/spi.c b/src/southbridge/amd/sb700/spi.c
index df44c04..caddfc8 100644
--- a/src/southbridge/amd/sb700/spi.c
+++ b/src/southbridge/amd/sb700/spi.c
@@ -35,11 +35,6 @@
 	return pci_read_config32(dev, 0xa0) & ~0x1f;
 }
 
-void spi_init(void)
-{
-	/* Not needed */
-}
-
 static void reset_internal_fifo_pointer(void)
 {
 	uint32_t spibar = get_spi_bar();

-- 
To view, visit https://review.coreboot.org/20039
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4c0cdbe2271fc7561becd87ad3b96bd45e77430
Gerrit-Change-Number: 20039
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>