[coreboot-gerrit] Change in coreboot[master]: util/cbfstool/lz4frame.c: Add comment to fall through

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Jun 5 15:26:16 CEST 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20036


Change subject: util/cbfstool/lz4frame.c: Add comment to fall through
......................................................................

util/cbfstool/lz4frame.c: Add comment to fall through

GCC7 has a new feature called -Wimplicit-fallthrough enabled by
default which checks for fallthrough in switch statements which is a
common error. When a fallthrough is actually intended a comment saying
so will satisfy GCC.

Fixes cbfstool not building with GCC7.

Change-Id: I83252fc96be7ce0971d4251b0fc88fbbd7440e71
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M util/cbfstool/lz4/lib/lz4frame.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/20036/1

diff --git a/util/cbfstool/lz4/lib/lz4frame.c b/util/cbfstool/lz4/lib/lz4frame.c
index e5458bb..f984b27 100644
--- a/util/cbfstool/lz4/lib/lz4frame.c
+++ b/util/cbfstool/lz4/lib/lz4frame.c
@@ -1091,7 +1091,7 @@
                 dctxPtr->tmpInTarget = minFHSize;   /* minimum to attempt decode */
                 dctxPtr->dStage = dstage_storeHeader;
             }
-
+	    /* Falls through. */
         case dstage_storeHeader:
             {
                 size_t sizeToCopy = dctxPtr->tmpInTarget - dctxPtr->tmpInSize;

-- 
To view, visit https://review.coreboot.org/20036
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83252fc96be7ce0971d4251b0fc88fbbd7440e71
Gerrit-Change-Number: 20036
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>



More information about the coreboot-gerrit mailing list