[coreboot-gerrit] Change in coreboot[master]: util/lint: Add check to make sure 'coreboot' is lowercase

Martin Roth (Code Review) gerrit at coreboot.org
Sun Jun 4 05:28:03 CEST 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20032


Change subject: util/lint: Add check to make sure 'coreboot' is lowercase
......................................................................

util/lint: Add check to make sure 'coreboot' is lowercase

- Excludes certain phrases which can't be changed.
- Checks last commit message if code is in a repo.

Change-Id: I6b52342488dacc56ef6083db5503507af35d41ac
Signed-off-by: Martin Roth <martinroth at google.com>
---
A util/lint/lint-stable-021-coreboot-lowercase
1 file changed, 33 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/20032/1

diff --git a/util/lint/lint-stable-021-coreboot-lowercase b/util/lint/lint-stable-021-coreboot-lowercase
new file mode 100755
index 0000000..0df70b8
--- /dev/null
+++ b/util/lint/lint-stable-021-coreboot-lowercase
@@ -0,0 +1,33 @@
+#!/bin/sh
+# This file is part of the coreboot project.
+#
+# Copyright (C) 2017 Google Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# DESCR: Verify that the word 'coreboot' is lowercase
+
+LC_ALL=C export LC_ALL
+
+EXCLUDE='^3rdparty/\|util/crossgcc/xgcc\|Binary file\|coreboot\|COREBOOT\|CorebootPayload\|CorebootModule\|minnowboard.org/Coreboot'
+
+# Use git grep if the code is in a git repo, otherwise use grep.
+if [ -n "$(command -v git)" ] && [ -d .git ]; then
+	GREP_FILES="git grep -in"
+
+	# Check last commit message
+	if [ -n "$(git log -n 1 | grep -i 'coreboot' | grep -v "$EXCLUDE" )" ]; then
+		echo "'coreboot' should be lowercase in commit message"
+	fi
+else
+	GREP_FILES="grep -rin"
+fi
+
+${GREP_FILES} "coreboot" | grep -v "$EXCLUDE";

-- 
To view, visit https://review.coreboot.org/20032
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b52342488dacc56ef6083db5503507af35d41ac
Gerrit-Change-Number: 20032
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>



More information about the coreboot-gerrit mailing list