[coreboot-gerrit] Change in coreboot[master]: [WIP]nb/intel/sandybridge/raminit: Advertise correct frequency
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Fri Jun 2 19:57:13 CEST 2017
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19995 )
Change subject: [WIP]nb/intel/sandybridge/raminit: Advertise correct frequency
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19995/1/src/northbridge/intel/sandybridge/raminit.c
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/#/c/19995/1/src/northbridge/intel/sandybridge/raminit.c@132
PS1, Line 132: 100 : 133
> nit: why not directly use 10000 and 13333? that avoids changing the output
I'm printing the refclk in use, see next line.
--
To view, visit https://review.coreboot.org/19995
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8481564fe96af29ac31482a7f03bb88f343326f4
Gerrit-Change-Number: 19995
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 02 Jun 2017 17:57:13 +0000
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list