[coreboot-gerrit] Change in coreboot[master]: soc/baytrail: add ACPI method to generate USB port info

Martin Roth (Code Review) gerrit at coreboot.org
Fri Jun 2 18:29:48 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19973 )

Change subject: soc/baytrail: add ACPI method to generate USB port info
......................................................................

soc/baytrail: add ACPI method to generate USB port info

Add ACPI method GPLD to generate port location data when
passed visiblity info.  Will be used by _PLD method in
board-specific USB .asl files.

Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
Reviewed-on: https://review.coreboot.org/19973
Reviewed-by: Martin Roth <martinroth at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/soc/intel/baytrail/acpi/xhci.asl
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Martin Roth: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/soc/intel/baytrail/acpi/xhci.asl b/src/soc/intel/baytrail/acpi/xhci.asl
index bef0b9f..d3c0083 100644
--- a/src/soc/intel/baytrail/acpi/xhci.asl
+++ b/src/soc/intel/baytrail/acpi/xhci.asl
@@ -23,6 +23,23 @@
 	Device (RHUB)
 	{
 		Name (_ADR, 0x00000000)
+
+		// GPLD: Generate Port Location Data (PLD)
+		Method (GPLD, 1, Serialized) {
+			Name (PCKG, Package (0x01) {
+				Buffer (0x10) {}
+			})
+
+			// REV: Revision 0x02 for ACPI 5.0
+			CreateField (DerefOf (Index (PCKG, Zero)), Zero, 0x07, REV)
+			Store (0x02, REV)
+
+			// VISI: Port visibility to user per port
+			CreateField (DerefOf (Index (PCKG, Zero)), 0x40, One, VISI)
+			Store (Arg0, VISI)
+			Return (PCKG)
+		}
+
 		Device (PRT1) { Name (_ADR, 1) }
 		Device (PRT2) { Name (_ADR, 2) }
 		Device (PRT3) { Name (_ADR, 3) }

-- 
To view, visit https://review.coreboot.org/19973
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad947ae2cd541d3407455b218c2b352b9a373718
Gerrit-Change-Number: 19973
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list