[coreboot-gerrit] Change in coreboot[master]: google/gru: enable the pull high for touchpad

[Caesar Wang (Code Review)]

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 )

Change subject: google/gru: enable the pull high for touchpad
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19863/2/src/mainboard/google/gru/romstage.c
File src/mainboard/google/gru/romstage.c:

Line 81: 	prepare_i2c();
> If the required delay is a full second, it should be okay to put this in ra
I think that's fine. Why should be put it in ramstage?


-- 
To view, visit https://review.coreboot.org/19863
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes