[coreboot-gerrit] Change in coreboot[master]: [WIP]soc/intel/apollolake: Add support in APL for PMC common...

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19375 )

Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code
......................................................................


Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/19375/10/src/soc/intel/apollolake/pmutil.c
File src/soc/intel/apollolake/pmutil.c:

PS10, Line 102: 
              : uint16_t print_pm1_status(uint16_t pm1_sts)
              : {
              : 	static const char *const pm1_sts_bits[] = {
why can't pm1_sts printing be moved to common code because the bits in here are anyway fixed in ACPI


-- 
To view, visit https://review.coreboot.org/19375
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes