[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel PMC support

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19349 )

Change subject: soc/intel/common/block: Add Intel PMC support
......................................................................


Patch Set 9:

(2 comments)

https://review.coreboot.org/#/c/19349/9/src/soc/intel/common/block/pmc/Makefile.inc
File src/soc/intel/common/block/pmc/Makefile.inc:

PS9, Line 5: verstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC) += pmc.c
does verstage use pmc functions ?


https://review.coreboot.org/#/c/19349/9/src/soc/intel/common/block/pmc/pmc.c
File src/soc/intel/common/block/pmc/pmc.c:

PS9, Line 245: 	if (IS_ENABLED(CONFIG_SOC_INTEL_APOLLOLAKE)) {
why only for APL ?


-- 
To view, visit https://review.coreboot.org/19349
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes