[coreboot-gerrit] Change in coreboot[master]: src/cpu/amd/quadcore Fix checkpatch errors/warnings
Philippe Mathieu-Daudé (Code Review)
gerrit at coreboot.org
Thu Jun 1 18:56:58 CEST 2017
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19987 )
Change subject: src/cpu/amd/quadcore Fix checkpatch errors/warnings
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/19987/1/src/cpu/amd/quadcore/amd_sibling.c
File src/cpu/amd/quadcore/amd_sibling.c:
PS1, Line 108: 8 * siblings + sysconf.nodes;
isn't it cleaner to align just after the "="?
https://review.coreboot.org/#/c/19987/1/src/cpu/amd/quadcore/quadcore.c
File src/cpu/amd/quadcore/quadcore.c:
PS1, Line 62: "Start
same here, align after the "("?
and so on
--
To view, visit https://review.coreboot.org/19987
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0a28c12e209547b3625f4ca1696f9c26dc2b6d0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Evelyn Huang <evhuang at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list