[coreboot-gerrit] Change in coreboot[master]: amd/gardenia: Init cbmem in romstage

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19752 )

Change subject: amd/gardenia: Init cbmem in romstage
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19752/2/src/mainboard/amd/gardenia/romstage.c
File src/mainboard/amd/gardenia/romstage.c:

Line 67: 	cbmem_initialize_empty();
> This should be in the SoC code. Really, this entire sequence is needs to be
I agree.  This all moves in the "Convert to C_ENVIRONMENT_BOOTBLOCK" patch https://review.coreboot.org/#/c/19755.  It felt like 6 vs. 0.5 dozen on which to do first.  Doing it this way allowed me to easily verify the other was working as expected.


-- 
To view, visit https://review.coreboot.org/19752
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ede71ec660678bb5f77693a9095aa0f198e4e26
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes