[coreboot-gerrit] Change in coreboot[master]: google/slippy: populate PEI SPD data for all channels

Matt DeVillier (Code Review) gerrit at coreboot.org
Thu Jun 1 16:02:33 CEST 2017


Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19981 )

Change subject: google/slippy: populate PEI SPD data for all channels
......................................................................


Patch Set 1:

not directly, no.  On BDW, mrc.bin populates the pei_data struct which is used to populate a CBMEM_INFO table and ultimately the SMBIOS table.  Os HSW, the mrc.bin doesn't do this, so I've added a patch to populate the data: #19958.  Even still, this doesn't eliminate the need for the spd_data struct in the pei_data to be populated for all/both sodimms/channels, which is what this patch does (basically bringing it in line with BDW)

-- 
To view, visit https://review.coreboot.org/19981
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e14b35642a3fbaecaeb7d1d33b5a7c1405bac45
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list