[coreboot-gerrit] Change in coreboot[master]: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK

Marc Jones (Code Review) gerrit at coreboot.org
Thu Jun 1 06:13:42 CEST 2017


Marc Jones has posted comments on this change. ( https://review.coreboot.org/19755 )

Change subject: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/19755/4/src/mainboard/amd/gardenia/bootblock/OemCustomize.c
File src/mainboard/amd/gardenia/bootblock/OemCustomize.c:

Line 128: };
some of this doesn't belong in the bootblock. So maybe lets split this file.


-- 
To view, visit https://review.coreboot.org/19755
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I811c7ef875b980874f3c4b1f234f969ae5618c44
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list